Improve memory footprint of ComputeNgramLmPerplexityJob .get_ppl#581
Merged
Improve memory footprint of ComputeNgramLmPerplexityJob .get_ppl#581
Conversation
michelwi
requested review from
Atticus1806,
DanEnergetics,
JackTemaki and
jtrmal
DanEnergetics
approved these changes
Feb 6, 2025
Contributor
|
One of the weirdest uses of dequeueue I have ever seen but LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation constructs a list of the entire files content in memory just to (almost) discard it immediately.
We found that this leads to high memory usage and can slow down the cluster head node (as this is a mini_task). Using a deque instead reduces the memory footprint drastically.