Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on parse #2

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ProbablyClem
Copy link
Collaborator

Depends on : this pr
It's a really small change but the diff is big because the refacto branch as not been merged yet

Panics if a file is not found/cannot be found

Currently, if a file doesn't exists, you get no warning at all.... which is very dangerous.

It's hard to spell the file name right cause there's no autocompletion so we need at least this safety guard

@rxdiscovery
Copy link
Owner

Hello,
It's good to have thought about error handling, when I developed this crate, it was to solve an urgent problem, I didn't have time to refine it, anyway if there's an error it will happen at the build process level and will never impact the final program.
But we still need good error handling, thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants