-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover module #3
Open
ProbablyClem
wants to merge
18
commits into
rxdiscovery:main
Choose a base branch
from
ProbablyClem:discover-module
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Hello, have you thought about external dependencies? that are not on the same crate? |
What do you mean by that ? |
for example, if you divide your project into several separate sub-projects, with the DTOs in one library and the controllers in another, how will you manage this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on this pr
Big PR that aim at being able to parse folders directly.
Currently you parse modules but using module.content only works if you have a module inside the file.
Now you can specify a directory and it will parse every files recursively.
With this new implementation, I don't need the module specification anymore because I infer it from the path, so I simplified the attributes with a new paths = "./paths1, ./path2" format which is easier to use.
The old syntax still works, I just ignore the module part.
For easier debugging, I splitted the project in 3 crates, which allows me to have most of the logic in a non-macro crate, where I can use print!(). It's way easier to debug that way !
I bumpted that projet to 4.0 because it's a big change