Skip to content

Add image size default for encoding. #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

tbro
Copy link
Contributor

@tbro tbro commented Jun 18, 2025

Adds default size to image encoding. Seems worthwhile since it simplifies the command line a lot for those that, like me, don't have any specific requirements on size.

Side note, I had to branch off an earlier commit since builds are failing on main. The patch should still apply to main though I expect.

@hschimke
Copy link
Collaborator

I'll review this, apologies on the main having some failing builds, I got pulled away part way through cleaning up a feature.

Copy link
Collaborator

@hschimke hschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may change the defaults later, but this is a good start. Thank you for the submission. Approved and merging soon.

@hschimke hschimke merged commit 80b8d97 into rxing-core:main Jul 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants