feat: Add '의 값 종류' operator for type checking #110
Conversation
This commit introduces a new operator '의 값 종류' (meaning 'type of value') that allows users to check the type of a given variable or expression. - Added `TypeOf` node in `core/node/misc.ts` to represent the new operator. - Updated `core/node/index.ts` to export the new `TypeOf` node. - Modified `core/prepare/parse/rule.ts` to include parsing rules for '의 값 종류'. - Added a new test case `test/codes/typeof.yak` and its expected output `test/codes/typeof.yak.out` to verify the functionality.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @rycont, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new typeof operator, 의 값 종류, to the language, allowing for dynamic type introspection of variables and expressions. The changes involve defining the operator's behavior in the core node system, integrating its parsing rules, and providing comprehensive test coverage to ensure its correct functionality.
Highlights
- New Language Feature: Implemented a new
의 값 종류(type of value) operator, enabling runtime type checking of variables and expressions within the language. - Core Node Definition: Introduced the
TypeOfclass incore/node/misc.tsto represent this new operator. This class handles the evaluation of an expression and returns its type's friendly name. - Parsing Rule Integration: Added a new rule to
core/prepare/parse/rule.tsthat correctly parses the[expression] 의 값 종류syntax, transforming it into aTypeOfnode during the parsing phase. - Test Coverage: Included new test cases in
test/codes/typeof.yakand their corresponding expected outputs intest/codes/typeof.yak.outto verify the functionality and correctness of the new type-checking operator.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| override async execute(scope: Scope): Promise<StringValue> { | ||
| const evaluated = await this.value.execute(scope) | ||
|
|
||
| return new StringValue((evaluated.constructor as typeof ValueType).friendlyName) |
There was a problem hiding this comment.
The current implementation relies on friendlyName to determine the type. If a ValueType subclass lacks a friendlyName static property, this will result in undefined. Consider providing a fallback to the class name itself for robustness.
| return new StringValue((evaluated.constructor as typeof ValueType).friendlyName) | |
| return new StringValue((evaluated.constructor as any).friendlyName || evaluated.constructor.name) |
This commit introduces a new operator '의 값 종류' (meaning 'type of value') that allows users to check the type of a given variable or expression.
TypeOfnode incore/node/misc.tsto represent the new operator.core/node/index.tsto export the newTypeOfnode.core/prepare/parse/rule.tsto include parsing rules for '의 값 종류'.test/codes/typeof.yakand its expected outputtest/codes/typeof.yak.outto verify the functionality.