Implement compound assignment #125

rycont · 2025-07-26T14:40:59Z

목록 = [1, 2, 3, 4, 5]
목록[0] += 10
목록[1] -= 2
목록[2] *= 3
목록[3] /= 2
목록[4] %= 3
목록 보여주기

…related tests

…examples

…r compound operators

gemini-code-assist

Summary of Changes

Hello @rycont, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant language enhancement by implementing compound assignment operators. This feature streamlines code by allowing in-place arithmetic and string operations on variables and list elements, improving readability and reducing verbosity. The changes span across the lexer, parser, and execution engine, ensuring full integration and robust error handling for these new operations.

Highlights

Core Language Feature: Implemented support for compound assignment operators (+=, -=, *=, /=, %=) for both variables and elements within lists. This allows for more concise code when updating values based on their current state.
Lexer and Parser Updates: Introduced a new ASSIGNER token type to differentiate between simple assignment (=) and compound assignment operators. The parsing rules were updated to recognize and handle these new operators, dynamically generating rules for each assigner.
Execution Logic Enhancement: Modified the SetVariable and SetToIndex execution logic to correctly apply the specified compound operation (e.g., addition, subtraction, multiplication) to the existing value before reassigning it. Robust error handling for type mismatches during these operations has also been added.
Documentation and Testing: Updated the language documentation to include a new section explaining compound assignment. Comprehensive unit tests have been added in a new file (test/compound-operator.test.ts) to validate the functionality and error handling of these new operators across various data types and scenarios.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces compound assignment operators like +=, -=, etc., for both variables and list elements. The implementation correctly touches on all necessary layers: tokenization, parsing, and execution. The use of ASSIGNERS.map to generate parsing rules is a clean approach that reduces code duplication. The new functionality is also well-tested with a new dedicated test file and additions to existing test cases.

My review includes two main suggestions for improvement:

A high-severity issue in the tokenizer where compound assignment operators are redundantly defined, which could lead to ambiguity.
A medium-severity issue regarding duplicated error-handling logic in the execution phase, which could be refactored to improve maintainability.

Overall, this is a great addition to the language. Addressing these points will make the implementation more robust and maintainable.

gemini-code-assist · 2025-07-26T14:43:16Z

core/prepare/tokenize/rules.ts

+    '+=',
+    '-=',
+    '*=',
+    '/=',


The OPERATORS array includes compound assignment operators (+=, -=, *=, /=). These are already handled by the ASSIGNER token rule.

Including them here is redundant and could lead to tokenization ambiguity or bugs in the future. These operators should be removed from the OPERATORS list to keep the concerns of operators and assigners separate.

gemini-code-assist · 2025-07-26T14:43:17Z

core/node/variable.ts

+            try {
+                newValue = tempOperator.call(oldValue, operand)
+            } catch (error) {
+                if (error instanceof YaksokError) {
+                    if (!error.tokens) {
+                        error.tokens = this.tokens
+                    }
+
+                    if (!error.codeFile) {
+                        error.codeFile = scope.codeFile
+                    }
+                }
+
+                throw error
+            }


This try...catch block is identical to the one in core/node/list.ts in the SetToIndex.execute method (lines 176-190). This code duplication can make future maintenance more difficult and error-prone.

To improve maintainability, I recommend extracting this error-handling logic into a shared helper function that can be used in both places. This will ensure consistency and make updates easier.

cloudflare-workers-and-pages · 2025-07-26T14:44:28Z

Deploying dalbit-yaksok with Cloudflare Pages

Latest commit:	`940ae3d`
Status:	✅ Deploy successful!
Preview URL:	https://52da4c5b.yaksok-ts.pages.dev
Branch Preview URL:	https://implement-compound-assignmen.yaksok-ts.pages.dev

View logs

rycont added 9 commits July 26, 2025 22:48

refactor: rename ASSIGNMENT to ASSIGNER in token handling and update …

127923e

…related tests

feat: implement +=

2362360

feat: add /= -= *= %=

1eb691c

feat: add modulus operator to assigners

9f4657f

feat: add arithmetic operations and update output for age calculations

271ddc0

feat: update variable section with compound assignment operators and …

6433b7e

…examples

feat: enhance error handling for variable assignment and add tests fo…

3f5b4b8

…r compound operators

feat: implement in index setter

fceb190

feat: compound assignment operations in set to index node

dde0fd2

gemini-code-assist bot reviewed Jul 26, 2025

View reviewed changes

chore: resolve circular improts

a002473

gemini-code-assist bot reviewed Jul 26, 2025

View reviewed changes

refactor: remove compound assignment operators from OPERATORS list

8efc3fa

rycont added 2 commits July 26, 2025 23:46

Merge branch 'main' into implement-compound-assignment

940ae3d

chore: bump package versions to 3.0.0-RC.4

dbe11fd

rycont merged commit 73e6a47 into main Jul 26, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement compound assignment #125

Implement compound assignment #125

Uh oh!

rycont commented Jul 26, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jul 26, 2025

Uh oh!

gemini-code-assist bot Jul 26, 2025

Uh oh!

cloudflare-workers-and-pages bot commented Jul 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Implement compound assignment #125

Implement compound assignment #125

Uh oh!

Conversation

rycont commented Jul 26, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 26, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 26, 2025

Choose a reason for hiding this comment

Uh oh!

cloudflare-workers-and-pages bot commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying dalbit-yaksok with Cloudflare Pages

Uh oh!

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Jul 26, 2025 •

edited

Loading