Skip to content

feat: impl FromStr / Display for FencingToken #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 25, 2025
Merged

feat: impl FromStr / Display for FencingToken #189

merged 3 commits into from
May 25, 2025

Conversation

shikhar
Copy link
Member

@shikhar shikhar commented May 25, 2025 •
edited
Loading

more generally, consistently implement these traits for validating newtypes on a String:

Deref<Target = str>
Display
FromStr
TryFrom<String>
From<T> for String

@shikhar shikhar requested a review from a team as a code owner May 25, 2025 13:48
@shikhar shikhar merged commit 6d76a59 into main May 25, 2025
3 checks passed
@shikhar shikhar deleted the fromstr-display branch May 25, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shikhar