update cran submission of v0.7

s3alfisc · Jan 3, 2022 · 93b8115 · 93b8115
1 parent 138b80b
commit 93b8115
Show file tree

Hide file tree

Showing 5 changed files with 440 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -34,7 +34,7 @@ Authors@R:
 Description: Implementation of the fast algorithm for wild cluster bootstrap 
              inference developed in Roodman et al (2019, STATA Journal) for 
              linear regression models 
-             https://journals.sagepub.com/doi/abs/10.1177/1536867X19830877?journalCode=stja, 
+             <doi:10.1177/1536867X19830877>, 
              which makes it feasible to quickly calculate bootstrap test 
              statistics based on a large number of bootstrap draws even for 
              large samples - as long as the number of bootstrapping clusters 

diff --git a/README.Rmd b/README.Rmd
@@ -41,7 +41,7 @@ The package's central function is `boottest()`. It allows the user to test univa
 
 The `fwildclusterboot` package currently supports multi-dimensional clustering and one-dimensional hypotheses. It supports regression weights, multiple distributions of bootstrap weights, fixed effects, restricted (WCR) and unrestricted (WCU) bootstrap inference and subcluster bootstrapping for few treated clusters [(MacKinnon & Webb, (2018))](https://academic.oup.com/ectj/article-abstract/21/2/114/5078969).
 
-If you are interested in the wild cluster bootstrap for IV models [(Davidson & MacKinnon, 2010)](https://www.tandfonline.com/doi/abs/10.1198/jbes.2009.07221]) or want to test multiple joint hypotheses, you can use the [wildboottestjlr](https://github.com/s3alfisc/wildboottestjlr) package, which is an R wrapper of the [WildBootTests.jl](https://github.com/droodman/WildBootTests.jl) Julia package. While `fwildclusterboot` is already quite fast (see the benchmarks below), 
+If you are interested in the wild cluster bootstrap for IV models [(Davidson & MacKinnon, 2010)](https://www.tandfonline.com/doi/abs/10.1198/jbes.2009.07221) or want to test multiple joint hypotheses, you can use the [wildboottestjlr](https://github.com/s3alfisc/wildboottestjlr) package, which is an R wrapper of the [WildBootTests.jl](https://github.com/droodman/WildBootTests.jl) Julia package. While `fwildclusterboot` is already quite fast (see the benchmarks below), 
 the implementation of the wild bootstrap for OLS in `WildBootTests.jl` is - after compilation - orders of magnitudes faster, in particular for problems with a large number of clusters.
 
 <!-- The following features will be added in the future:  -->

diff --git a/README.md b/README.md
@@ -47,8 +47,8 @@ subcluster bootstrapping for few treated clusters [(MacKinnon & Webb,
 
 If you are interested in the wild cluster bootstrap for IV models
 [(Davidson & MacKinnon,
-2010)](https://www.tandfonline.com/doi/abs/10.1198/jbes.2009.07221%5D)
-or want to test multiple joint hypotheses, you can use the
+2010)](https://www.tandfonline.com/doi/abs/10.1198/jbes.2009.07221) or
+want to test multiple joint hypotheses, you can use the
 [wildboottestjlr](https://github.com/s3alfisc/wildboottestjlr) package,
 which is an R wrapper of the
 [WildBootTests.jl](https://github.com/droodman/WildBootTests.jl) Julia

diff --git a/cran-comments.html b/cran-comments.html
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,3 +1,24 @@
+## Re-submission of 0.7
+
+Fixed both issues below:
+
++   Found the following (possibly) invalid URLs:
+     URL: https://www.tandfonline.com/doi/abs/10.1198/jbes.2009.07221%5D
+       From: README.md
+       Status: 404
+       Message: Not Found
+
+The closing %5D = "]" should likely be removed.
+
+
+
++   The Description field contains
+
+https://journals.sagepub.com/doi/abs/10.1177/1536867X19830877?journalCode=stja,
+
+Please write DOIs as <doi:10.1177/1536867X19830877> in the Description
+field without the rest of the URL.
+
 ## Version 0.7
 
 - checks pass on github actions: windows, mac, ubuntu