Skip to content

Commit bf3d289

Browse files
committed
further cran submission error fixes related to suggests & vignette
1 parent 8c74535 commit bf3d289

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

cran-comments.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
1+
## Version 0.3.6 submission, Resubmission 2
2+
3+
+ Another error due to "noSuggests" / vignette - package fixest was used, but not loaded
4+
5+
16
## Version 0.3.6 submission, Resubmission
27

3-
+ Adressed errors related to suggestsdescribed below (reason for error; unprotected library(lfe) statements in tests)
8+
+ Adressed errors related to suggests described below (reason for error; unprotected library(lfe) statements in tests)
49
+ noSuggests error due to missing library("pkg") statements in vignette
510
+ lfe now install on ubuntu dev
611

vignettes/fwildclusterboot.Rmd

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,9 +234,9 @@ If regression weights are specified in the estimation stage via `lm()`, `feols()
234234

235235
```{r}
236236
# regression with weights / WLS
237-
lm_w_fit <- feols(proposition_vote ~ treatment + ideology1 + log_income, weights = voters$weights, data = voters)
237+
lm_w_fit <- lm(proposition_vote ~ treatment + ideology1 + log_income, weights = voters$weights, data = voters)
238238
239-
boot_feols <- boottest(lm_w_fit,
239+
boot_w_lm <- boottest(lm_w_fit,
240240
clustid = "group_id1",
241241
param = "treatment",
242242
B = 9999)
@@ -250,7 +250,7 @@ A major bottleneck for the performance of `boottest()` is a large matrix multipl
250250
The number of threads can be specified via the `nthreads` argument of `boottest()`:
251251

252252
```{r, eval = FALSE}
253-
boot_feols <- boottest(lm_fit,
253+
boot_lm <- boottest(lm_fit,
254254
clustid = "group_id1",
255255
param = "treatment",
256256
B = 9999,

0 commit comments

Comments
 (0)