Added support for inline audio for mp3, aac, wav.#257
Open
PrimateCoder wants to merge 1 commit intos9e:masterfrom
Open
Added support for inline audio for mp3, aac, wav.#257PrimateCoder wants to merge 1 commit intos9e:masterfrom
PrimateCoder wants to merge 1 commit intos9e:masterfrom
Conversation
This renders the filename in the URL for context, with the audio player immediately below.
Author
|
I got a bit ahead of myself. I'll add tests to this and update this PR by the weekend. But it does work, you can see it in action here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renders the filename in the URL for context, with the audio player immediately below.