Multiple choice qs #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@manics in case we hadn't told you already, we moved your notebook into this open repo and factored out some of the data loading/cleaning steps to a script so it's easy to make new notebooks/scripts that can quickly load up the same dataframe you used - this PR has a separate nb that just produces some tables for the GH issues |
manics
reviewed
May 23, 2023
Comment on lines
+20
to
+27
| "from datetime import datetime \n", | ||
| "import matplotlib\n", | ||
| "import matplotlib.pyplot as plt\n", | ||
| "import numpy as np\n", | ||
| "import pandas as pd\n", | ||
| "# Requires openpyxl for read_excel\n", | ||
| "from pathlib import Path\n", | ||
| "import re\n", |
Member
There was a problem hiding this comment.
Are you planning to extend this notebook later? Most of these imports are unused.
Collaborator
Author
There was a problem hiding this comment.
Not at present, this is just a lazy copy and paste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.