Skip to content

feat: add custom color picking and hex code input to the theme generator #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SamuelLHuber
Copy link

addresses #3970

@saadeghi saadeghi self-assigned this Jun 28, 2025
@saadeghi
Copy link
Owner

Thanks for the PR.
There are some parts that I need to change.

  1. The default browser color picker is RGB and doesn't allow P3 colors so I don't think it's a good idea to use that. Also dragging colors in the color picker is laggy because the URL of the page changes live based on the chosen color.
  2. the layout doesn't look good
  3. the conversion is doesn't always work and is values are not validated. for example if you write red in custom color field, it shows NaN which is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants