feat: button improvements and cleanup #4261
Open
+25
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as pointer-events-none
…ed links, do not remove underline - I think removing underline on mobile on hover was introduced by mistake - there is nothing else to suggest that underline should be removed
- disabled btn cannot have hover because of pointer-events-none
- disabled buttons do not have hover
- disabled buttons do not have hover
disabled buttons do not have hover
- from my tests tailwind accepts this and creates classes modified with variants as required
pdanpdan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: unify styles for btn-outline and btn-dash
feat: respect input:checked for btn-soft, cleanup
feat: respect input:checked for btn-ghost
feat: cleanup btn-dash
feat: cleanup btn-outline
feat: use color defined by modifier for btn-ghost
feat: remove rules for :hover on disabled button because it already has pointer-events-none
feat: use color defined by modifier for btn-link, do not color disabled links, do not remove underline
feat: do not remove underline from btn-link when it is in
prose not-proseexample: https://play.tailwindcss.com/Gk9Jv0Vs6v?file=css