Improvement Dockerfile and Common Code #706
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the user information (i.e., username, first_name, last_name, email etc.) handling in the codebase. Previously, the values was hardcoded. Now, the values are dynamically generated using a template literal, incorporating the users.
This pull request proposes modifications to the Dockerfile to enhance its efficiency and maintainability. Below are the key changes:
2.1. Optimized COPY Command:
Reorganized the COPY command to prioritize copying package.json and package-lock.json files before installing dependencies. This optimizes Docker's layer caching mechanism, reducing build times for subsequent builds.
2.2. Consolidated RUN Commands:
Combined multiple RUN commands into a single instruction to minimize the number of layers in the Docker image. This improves build performance and streamlines the build process.
Made minor adjustments to the Dockerfile structure for consistency and adherence to best practices.
No functional changes were made, and the code remains stable.
Please review and merge this update as appropriate.
Thank you.