Fix: fetch public files (profile.json, blog.json) from public url #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
i tried above solution and it worked . Thanks |
AmrElsayyad
force-pushed
the
fix-fetch
branch
2 times, most recently
from
98b2497 to
88d4332
Compare
…ge of `rss2json` API with `feed2json` package to fix errors Signed-off-by: Amr ElSayyad <[email protected]>
for more information, see https://pre-commit.ci
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@saadpasta Please, review this PR and tell me if anything need to change. |
Signed-off-by: Amr ElSayyad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a fix for fetching public files (
profile.json,blogs.json) from the site's public URL instead of the root (/) path. This change addresses an issue where the files were not found when deployed at a different path, ensuring that GitHub profiles and Medium blogs are displayed as intended.Also, fetch Medium blogs directly from Medium feed and replace the usage of
rss2jsonAPI withfeed2jsonpackage to fix errors fetching from the API.Fixes #655
Type of change