Various tools for de-streaking #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are the parameters that are worth keeping after some experimental tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can be split into two major contributions:
DirectionalStatisticas an argument. Implementations of this interface specify how rays are cast by sampling from a distribution on the unit circle.DirectionalStatistic: one that yields a completely random direction, and one that prefers a certain direction (e.g., for inpainting streaks).StreakFinderclass that generates a mask of the streaks (which can be used to de-streak, or just to compile statistics about streaking).StreakStatisticsClient: a spark client that computes the streak mask for every tile in a stack, transforms the mask according to the transformations stored in the tile'sTileSpec, and accumulates streak severity over a grid of the layers (similar to cross-correlation). Processing a single tile takes about 20s on the slower nodes of the Janelia cluster.The changes in this PR are mostly additive, so it doesn't clash with any existing code. However, I'm happy about any comments regarding duplication of functionality or hints about how to improve the spark parallelization of
StreakStatisticsClient.