[WIP] s3Opener: add query params for mixed and non-aws s3 resources #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for s3 uris using custom profile/region/endpoints via query parameters. Our use case likely involves multiple non-aws s3 sources, which the current s3opener does not support.
I marked this as WIP as I have not really seen people use query parameters in s3 uris this way, but it seems that parsing these options in a uri would be the logical way to point somewhere. I am open to other ideas and would be happy to implement the other config/credential arguments into the uri somewhere in another commit.