-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flow examples #37
Open
andreivladbrg
wants to merge
8
commits into
main
Choose a base branch
from
feat/flow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: update PRBMath build: add flow/lockup foundry profiles feat: implement a FlowUtilities library feat: implement flow creator contract refactor: rename v2 to lockup chore: add scripts in package json for the new profiles
andreivladbrg
force-pushed
the
feat/flow
branch
from
October 3, 2024 13:41
3dcfadb
to
da161e5
Compare
Closed
@andreivladbrg this might need some refactor with the |
indeed it needs, will updated it also, since the repo is public now, it can be removed via |
build: install flow repo via package.json test: add tests for FlowStreamCreator test: add tests for FlowBatchable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36
Note: this PR merge must be synchronized with docs reference changes due to
v2
rename tolockup
(e.g. this one). Will work on that once you finish with your refactor @smol-ninja.The
flow
example contracts are represented by these 4:FlowBatchable
adjustRatePerSecondAndDeposit
,createMultiple
,createAndDepositViaBroker
etc.) to declare the calldata as bytes for multiple function calls into a single txFlowManager
FlowStreamCreator
FlowUtilities
rps
using a desired amount and duration.@sablier-labs/solidity lmk if you have anything else in mind, or if the current ones should suffice