feat: scaffold bridge datasource #2571
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
force-pushed
the
feat/lifi-datasource
branch
from
519569a to
d12b702
Compare
iamacook
commented
May 22, 2025
| @@ -0,0 +1,179 @@ | |||
| import type { HttpErrorFactory } from '@/datasources/errors/http-error-factory'; | |||
There was a problem hiding this comment.
This negates needing to use the SDK. We should remove the methods which are not needed and reduce complexity of those which are. On top of that, we should only validate the properties which are required for mapping.
schmanu
reviewed
May 26, 2025
src/routes/transactions/mappers/common/bridge-transaction.mapper.ts
Outdated
Show resolved
Hide resolved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially resolves #2560
In order to decode bridge transactions, we need to get a quote and/or status for transactions. This adds the relevant datasource in order to do so.
Changes
IBridgeApiwith relevant factoryIBridgeRepositorywith relevant schema inferred entities