fix: Improve error handling and add await for async mapping in transaction-info.mapper #2653
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction-info.mapper - Updated error handling to log errors as critical instead of throwing them directly which breaks the transaction flow. - Added 'await' keyword to the mapSwap method call to ensure proper asynchronous execution and error handling.
compojoom
reviewed
Jul 17, 2025
| @@ -131,7 +131,7 @@ export class MultisigTransactionInfoMapper { | |||
| if (error instanceof NotFoundException) { | |||
| this.loggingService.warn(error); | |||
| } else { | |||
| throw error; | |||
| this.loggingService.error(error); | |||
There was a problem hiding this comment.
Ok, but what are we then mapping below if we have an exception here? why is the code afterwards not throwing exceptions?
There was a problem hiding this comment.
The mapper checks the type of the TX and tries to map accordingly, but in case no type is found to map, it returns it as a custom transaction:
compojoom
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves an issue where transaction history was being blocked due to decoding errors in
Bridge/Swapoperations. Instead of throwing an exception that halts the process, the error is now logged to allow the flow to continue gracefully. Additionally, themapSwapmethod call has been updated with theawaitkeyword to ensure proper asynchronous handling, which helps in capturing and managing errors effectively.Changes