-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky simplicial set test #38940
base: develop
Are you sure you want to change the base?
Conversation
a55c33f
to
df9ba13
Compare
df9ba13
to
1830861
Compare
Documentation preview for this PR (built with commit f070aa3; changes) is ready! 🎉 |
The failed test is
This is obviously #38889 instead. By the way, GitHub Actions doesn't seem to be able to report test failure to the GitHub interface? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The change looks good to me, as far as I understand the problem. But it would be good if someone more familiar with the code has a look at well.
Marking it already as "ci fix" so that other PRs don't keep falling because of this issue.
Since there is no actual code being changed (just doctests), I see no risk in accepting it. |
There's always the risk of accidentally telling the user "this is the right way to do things" while it actually relies on dangerous internal implementation detail e.g. are you sure that the 1-cell is not shared between different objects, and mutate it is safe? |
Fixes #38888 .
This test has been failing sporadically recently e.g. https://github.com/sagemath/sage/actions/runs/11733902583/job/32689016794?pr=38938 .
From my understanding of simplicial set, the two
sigma_1
are actually representing two different cells (the wedge looks like a "8" shape), but because they both come fromS1
(the 1-sphere i.e. circle), they get the same name.SageMath does some magic during doctest so that dict entries are sorted, but the problem is
so with some chance it fails.
This change should make it deterministic --- since the two faces are named
sigma_1
andsigma_1'
, the comparison should be by custom name…?📝 Checklist