Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when specify invalid base for RR and RIF construction #39001

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Nov 19, 2024

As in the title.

Note that currently ZZ(str, base=int) only support 2 to 36. Should this be changed for consistency?

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview. (There's no change in documentation.)

⌛ Dependencies


The test on Conda (Mac) fails with

2024-11-19T04:02:36.0696760Z ./bootstrap: line 142: aclocal: command not found
2024-11-19T04:02:36.0697900Z Bootstrap failed. Either install autotools; or run bootstrap with
2024-11-19T04:02:36.0698610Z the -d option to download the auto-generated files instead.

Looks unrelated.

Another one (Ubuntu 3.9) is

2024-11-19T04:26:04.0471925Z **********************************************************************
2024-11-19T04:26:04.0591101Z File "src/sage/plot/plot.py", line 1857, in sage.plot.plot.plot
2024-11-19T04:26:04.0591946Z Failed example:
2024-11-19T04:26:04.0592761Z     plot(f, (x, -3.5, 3.5), detect_poles='show', exclude=[-3..3],
2024-11-19T04:26:04.0593588Z          ymin=-5, ymax=5)
2024-11-19T04:26:04.0594061Z Expected:
2024-11-19T04:26:04.0649808Z     Graphics object consisting of 12 graphics primitives
2024-11-19T04:26:04.0650471Z Got:
2024-11-19T04:26:04.1009273Z     Graphics object consisting of 13 graphics primitives
2024-11-19T04:26:26.6704957Z **********************************************************************

Also looks unrelated. Reported in #39002.

Copy link

github-actions bot commented Nov 19, 2024

Documentation preview for this PR (built with commit 91063db; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729 user202729 force-pushed the fix-real-construct-invalid-base branch from 91063db to ff9d834 Compare November 19, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant