Skip to content

New ray class #39525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 36 commits into
base: develop
Choose a base branch
from
Draft

New ray class #39525

wants to merge 36 commits into from
+1,729 −38

Conversation

@fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Feb 14, 2025

this is a revival of #15829

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@fchapoton
Copy link
Contributor Author

fchapoton commented Feb 14, 2025

@AurelPage
j'ai rebasé, mais il reste du boulot

@fchapoton fchapoton added the sd128 tickets of Sage Days 128 Le Teich label Feb 14, 2025
@fchapoton fchapoton marked this pull request as draft February 14, 2025 09:24
@github-actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Documentation preview for this PR (built with commit e675d41; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729 user202729 mentioned this pull request Feb 14, 2025
Merged
5 tasks
@fchapoton
Copy link
Contributor Author

fchapoton commented Feb 15, 2025 •
edited
Loading

The 2 failing doctests in src/sage/modular/hecke_character.py should be easy to fix by an expert in the field.

@fchapoton
Copy link
Contributor Author

fchapoton commented Feb 18, 2025

J'ai le sentiment de me mélanger les pinceaux entre bnrinit et gcharinit. Je crois que le ticket parle plutot du "ray class group". Un expert pourrait-il aider à clarifier les choses ? en particulier concernant la fonction L ?

@AurelPage
Copy link
Contributor

AurelPage commented Feb 18, 2025

Frédéric, ne touche pas aux gchar pour le moment. bnrinit permet de calculer des groupes de classes de rayon et leurs caractères, qui sont exactement les caractères de Hecke d'ordre fini. gcharinit permet de traiter les caractères de Hecke arbitraires, donc potentiellement d'ordre infini et potentiellement transcendants, je pense qu'il vaut mieux garder ça pour un travail d'intégration séparé.

@fchapoton
Copy link
Contributor Author

fchapoton commented Feb 21, 2025

ok, les fonctions L marchent, mais il manque encore de la doc. Et surtout l'aide d'un specialiste pour me dire si les doctests qui ne passent pas sont des erreurs au sens mathematique ou pas.

@AurelPage
Copy link
Contributor

AurelPage commented Feb 21, 2025

Merci ! Je vais regarder mais je n'aurai pas trop le temps avant une semaine.

@fchapoton fchapoton mentioned this pull request Jul 10, 2025
Draft
5 tasks
@fchapoton
Copy link
Contributor Author

fchapoton commented Jul 23, 2025

@edgarcosta @JohnCremona I would appreciate help from experts in the field, so please tell LMFDB people that could be interested to come and have a look. I am not able to tell if the doctest failures are problematic or not.

edgarcosta
edgarcosta reviewed Nov 26, 2025
View reviewed changes
src/sage/rings/number_field/number_field_ideal.py
hnf = P.idealred(self.pari_hnf())
gens = self.__elements_from_hnf(hnf)
return K.ideal(gens)
R = K.ray_class_group(modulus) #find any ray class group of this modulus?
Copy link
Member

@edgarcosta edgarcosta Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not follow the comment

@edgarcosta
Copy link
Member

edgarcosta commented Nov 26, 2025

Overall it looks okay.
There is a bunch of commented code that could be removed.
I would also suggest add more tests, in particular some harder tests.

@fchapoton
Copy link
Contributor Author

fchapoton commented Nov 26, 2025

The current tests fail and I have no way to know what to do about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@edgarcosta edgarcosta edgarcosta left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: number theory sd128 tickets of Sage Days 128 Le Teich

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fchapoton @AurelPage @edgarcosta @rharron