-
-
Notifications
You must be signed in to change notification settings - Fork 631
Interface for Regina (3-manifold topology and normal surface theory) #40370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
soehms
wants to merge
10
commits into
sagemath:develop
Choose a base branch
from
soehms:add_regina
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Documentation preview for this PR (built with commit 35d7ca1; changes) is ready! 🎉 |
All relevant CI-tests passed including the ones that have the optional package install (Linux Incremental except the one for Fedora 41 which failed by unrelated reason). For example for Debian bookworm wie have:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to resolve the old Trac ticket #17077 (now a GitHub issue). This branch is based on the branch of Trac ticket #31456, which addressed the implementation of the optional
SPKG
.In the latter ticket it was noted that the package is not compatible with 32-bit systems and is therefore considered experimental (see #31456 (comment)). According to #31456 (comment), this should now be resolved. However, I haven't verified this yet. Are there still CI runs for this? Is this still a policy?
If this issue turns out to have resisted, I will change the type to experimental.
This PR initiates the integration of Regina via the Sage interface framework. Most of the basics should be included, but given Regina's broad functionality, this PR is still selective focusing on some applications of knot theory. However, future extensions should now be fairly straightforward. Explicitly it starts with the following specific conversions:
📝 Checklist
⌛ Dependencies