-
-
Notifications
You must be signed in to change notification settings - Fork 704
introduce the category of graded lattices #40945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Documentation preview for this PR (built with commit f1db531; changes) is ready! 🎉 |
|
@tscrim, would you please have a look if you can ? |
|
I'm a little worried about this because it introduces a subtle conflict with the graded functorial constructions. It becomes easy to accidentally declare it as an axiom for non-posets. In somr ways, "Ranked" is a better choice, but that is, of course, a slightly different (more general) concept. I feel like we should try to find a slightly different name to avoid the conflict. Maybe "GradedByChains"? That's a bit long though... @nthiery Do you have any thoughts about this? |
|
I do not think that Nicolas is listening. Somewhere in our doc, it is written that one should be able to use the same axiom name in unrelated domains without too much issues. But the "Graded" functorial construction is not an axiom, probably ? |
|
Thank you for the continued progress on posets and lattices!
Yeah, more or less. I actually do get notifications on explicit mentions :-) But not necessarily active though if I don't have up to date information ... In the case at hand, as far as I can remember, it should be completely safe to have a functorial construction and an axiom with the same name, as long one never construct a category deriving both from So the questions are:
If in doubt, the axiom for posets could be called with a disambiguated name e.g. Btw: should the graded axiom be defined more generally for posets? Altogether, I don't have opinions in one or the other direction. Cheers, |
|
Concerning question 1, I would not expect this to happen. Cocnerning question 2. Only advanced users can see that possible confusion, maybe they will know enough ? I am currently not introducing axioms for posets, only axioms for lattices. My aim is to move some methods to the appropriate category and also to introduce at least one new method in the correct place. So I would prefer to keep "Graded" as an axiom for lattices. |
|
I understand that you only want to introduce axioms for lattices now, but are you excluding the possibility of having axioms for posets at some point in the future? On the other hand, if we have a graded poset which is also a module, I can imagine that the most natural grading of the module is the same as the grading of the poset. However, I don't know. How much does it hurt to call the axiom "GradedAsOrder"? |
|
I do not exclude to introduce axioms for posets later. Maybe "Bounded" (having 0 and 1) would be the first one coming to my mind. |
|
@nthiery Thank you for responding. Sorry for taking some time for my response.
It might also have similar such conflicts as “graded” is something that can get used more often in other contexts… So I am more firmly thinking we need to have a different name for this axiom. The correct place to introduce this axiom would be in posets. IMO it would be better to add it to the correct place and just be done with it. |
|
Would I tried and failed to introduce a |
f1db531 to
a27c0c5
Compare
tscrim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very sorry for not being able to get to this faster.
I think chain graded is a very good name for this axiom.
What you've done mostly looks good for the implementation except for what I noted. What's not working correctly?
| A trim and graded lattice is distributive. | ||
| EXAMPLES:: | ||
| sage: FiniteLatticePosets().Trim().ChainGraded() | ||
| Category of finite distributive lattice posets | ||
| """ | ||
| return self._with_axiom("Distributive") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't the correct way to introduce this relation. You either want to use extra_super_categories to add the distributive lattices as a supercategory or the same mechanism used for Wedderburn's theorem.
|
Thanks, Travis. Now I would prefer to do #41216 first, if this makes sense. |
as this will be a useful thing to have
sequel of #39554 and #40705
📝 Checklist