Skip to content

Conversation

@Kushagra0811
Copy link

This PR fixes missing documentation and coverage warnings in src/sage/algebras/letterplace/free_algebra_letterplace.pyx.

Specifically:

  • Added missing docstring and EXAMPLES for generator_degrees.
  • Added docstrings and TESTS for __init__ and __cinit__ (indirect doctests).
  • Fixed grammatical typos in degbound and set_degbound ("In order to avoid we get..." -> "To avoid getting...").

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@Kushagra0811 Kushagra0811 changed the title Fix missing documentation and typos in free_algebra_letterplace Fix missing documentation and typos in free_algebra_letterplace.pyx Nov 21, 2025
@cxzhong
Copy link
Contributor

cxzhong commented Nov 22, 2025

@roed314 Workflows please

@roed314
Copy link
Contributor

roed314 commented Nov 22, 2025 via email

@Kushagra0811
Copy link
Author

Hi! This is my first contribution to SageMath so I'm still learning the workflow. I checked the failed logs for the Build documentation / doc -html and there seems to be a [Errno 28] No space left on device Error, which doesn't look like an issue in the code, could it be fixed by restarting the workflow?

@roed314
Copy link
Contributor

roed314 commented Nov 24, 2025

Could be; I restarted it.

@cxzhong
Copy link
Contributor

cxzhong commented Nov 24, 2025

Hi! This is my first contribution to SageMath so I'm still learning the workflow. I checked the failed logs for the Build documentation / doc -html and there seems to be a [Errno 28] No space left on device Error, which doesn't look like an issue in the code, could it be fixed by restarting the workflow?

We are investigating this. Do not care about it.

@cxzhong
Copy link
Contributor

cxzhong commented Nov 25, 2025

Seems CI agrees that

@cxzhong
Copy link
Contributor

cxzhong commented Nov 26, 2025

LGTM. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants