-
-
Notifications
You must be signed in to change notification settings - Fork 704
some cares about compiler warnings #41234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
dcoudert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not check all default values you assigned, in particular in code/methods that I don't know.
|
|
||
| cdef int i | ||
| cdef int x_min = 0 | ||
| cdef int x_max = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is something wrong in this method. if xmax is None, then x_max is set to self.n. Otherwise, it will remain to the default value you assigned, that is 0.
Why not doing like:
if xmin is None:
xmin = 0
if xmax is None:
xmax = self.n
for i in range(xmin, xmax):
...
| # (of length shortest_path_length). | ||
| cdef int meeting_vertex = -1 | ||
| cdef double shortest_path_length | ||
| cdef double shortest_path_length = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this cannot be initialized to 0. IT should be +oo
| # (of length shortest_path_length). | ||
| cdef int meeting_vertex = -1 | ||
| cdef double shortest_path_length | ||
| cdef double shortest_path_length = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be initialized to large value +oo
📝 Checklist
⌛ Dependencies