Skip to content

Conversation

@tobiasdiez
Copy link
Contributor

Add all flaky tests tracked at https://github.com/orgs/sagemath/projects/1 to the list in CI, so that those get automatically rerun in case of (random) failure.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729
Copy link
Contributor

this mechanism is too coarse-grained (it retries the whole set of files instead of just the one flaky test), but adding per-test flaky marker takes some work...

#39539

I don't like having two separate lists (one for the mapping, the other for the files) though. Ideas?

@user202729
Copy link
Contributor

actually there's an "easy" solution for per-test flaky that doesn't sacrifice other tests in the same file: add # not tested (flaky) to each of these tests, then add a separate file that retries as needed.

As I mentioned, most of these tests only cause a Python-handle-able error on failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants