more algorithms for .torsion_basis() over {finite, number, ""} fields #41530
+258
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an implementation of the method for general fields (including number fields), as well as adding new algorithms for the method over finite fields. With this, we address the comment
in
src/sage/schemes/elliptic_curves/ell_finite_field.py.The purpose of the "random" algorithm is to address the issue that the current implementation often wastes a lot of time (sometimes exponential) on computing the entire structure of the group of rational points, when in reality only a small subgroup is needed. Here's an example that showcases this problem:
Output: