Feat/add missing adapter methods #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ENOENT error handling in find, findOne, and count methods - Return empty results instead of crashing when directories don't exist - Add defensive programming for query.criteria.select when undefined - Properly handle omit fields when select criteria is not provided This allows applications to start successfully even when content directories haven't been created yet, and prevents crashes from Sails archive system when archiveModelIdentity is not properly configured. Closes #10
- Add create, createEach, update, destroy methods as no-ops - Add setSequence method for auto-increment sequence handling - Implement proper fetch behavior - only return data when query.meta.fetch is true - Fix Waterline warnings about unexpected return values when fetch not enabled - Ensure adapter compatibility with Sails auto-migration process This makes the adapter fully compatible with Waterline's expected interface while maintaining its read-only nature for content management. Closes #12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12