Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 簡易的にBunとマイグレーションを導入 #96

Open
wants to merge 31 commits into
base: feat/project-user
Choose a base branch
from
Open

feat: 簡易的にBunとマイグレーションを導入 #96

wants to merge 31 commits into from
+646 −278

Conversation

yukikamome316
Copy link
Member

必要最低限で動く程度に導入しました。
APIの仕様は変わっていません。

@yukikamome316 yukikamome316 self-assigned this Nov 8, 2023
@yukikamome316 yukikamome316 linked an issue Nov 8, 2023 that may be closed by this pull request
マイグレーションを導入 #29
Open
sor4chi
sor4chi reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@sor4chi sor4chi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmd/server以下にロジックが詰められてる状態になってるから
handlerはhandler.goをrootに作ってそれを呼び出すような形にするといいかも

@sor4chi
Copy link
Member

sor4chi commented Nov 9, 2023

よさそう、後でみます

@yukikamome316
Copy link
Member Author

コンフリクト解消したのでレビューお願いします

sor4chi
sor4chi requested changes Dec 14, 2023
View reviewed changes
Copy link
Member

@sor4chi sor4chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

まずレビュー進める前にドキュメント追加してください！

sor4chi
sor4chi requested changes Dec 14, 2023
View reviewed changes
Copy link
Member

@sor4chi sor4chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえずこれだけ

scripts/migrate.sh Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
backend/Dockerfile Outdated Show resolved Hide resolved
sor4chi
sor4chi requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@sor4chi sor4chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一つだけ

README.md Show resolved Hide resolved
@sor4chi
Copy link
Member

sor4chi commented Dec 18, 2023

@a01sa01to レビューできる？もし時間なかったら他の人に振ってもOK

a01sa01to
a01sa01to approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@a01sa01to a01sa01to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

みてなかったー、たぶん OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sor4chi sor4chi sor4chi approved these changes

@a01sa01to a01sa01to a01sa01to approved these changes

Assignees

@yukikamome316 yukikamome316

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

マイグレーションを導入
3 participants
@yukikamome316 @sor4chi @a01sa01to