Update Node to v20 (part 1)

[witoszekdev]

Scope of the change

This PR updates node to version 20, while still allowing to use Node 18 (to be removed in Next PR).

Note

Coverage is calculated incorrectly, we never tested "catch" block in our tests, tests didn't work because Intl behaved differently on Node 18 vs 20

Macaw-ui

Old macaw-ui versions don't support Node 20, because it specifically lists Node 18 as only allowed version:

npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@saleor/[email protected]',
npm warn EBADENGINE   required: { node: '>=16 <19' },
npm warn EBADENGINE   current: { node: 'v20.18.0', npm: '10.8.2' }
npm warn EBADENGINE }

However after checking macaw direct dependencies this is not required by any of them:

{
  "package": "node_modules/aria-hidden",
  "engines": {
    "node": ">=8.5.0"
  },
  "dependencyType": "directDependency"
}
{
  "package": "node_modules/clsx",
  "engines": {
    "node": ">=6"
  },
  "dependencyType": "directDependency"
}
{
  "package": "node_modules/downshift/node_modules/@babel/runtime",
  "engines": {
    "node": ">=6.9.0"
  },
  "dependencyType": "directDependency"
}
{
  "package": "node_modules/object-assign",
  "engines": {
    "node": ">=0.10.0"
  },
  "dependencyType": "directDependency"
}

same with peer dependencies (e.g. @material-ui/core).

This means that this error can probably be safely ignored

[changeset-bot]

🦋 Changeset detected

Latest commit: f4eb41e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
saleor-dashboard	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Differences Found

✅ No packages or licenses were added.

Summary

Expand

License Name	Package Count	Packages
0BSD	1	Packages tslib
BlueOak-1.0.0	1	Packages path-scurry
CC0-1.0	1	Packages type-fest
MIT/X11	1	Packages nub
MPL-1.1	1	Packages harmony-reflect
MPL-2.0	1	Packages dompurify
Public Domain	1	Packages jsonify
Python-2.0	1	Packages argparse
WTFPL	1	Packages opener
CC-BY-4.0	2	Packages @saleor/macaw-ui caniuse-lite
<<missing>>	3	Packages busboy saleor-dashboard streamsearch
BSD-2-Clause	24	Packages @typescript-eslint/parser @typescript-eslint/typescript-estree browser-process-hrtime css-select css-what domelementtype domhandler domutils dotenv dotenv-expand entities escodegen eslint-scope espree esprima esrecurse estraverse esutils nth-check stringify-object And 4 more...
BSD-3-Clause	45	Packages @humanwhocodes/object-schema @sentry/cli @sentry/cli-darwin @sentry/cli-linux-arm @sentry/cli-linux-arm64 @sentry/cli-linux-i686 @sentry/cli-linux-x64 @sentry/cli-win32-i686 @sentry/cli-win32-x64 @sinonjs/commons @sinonjs/fake-timers abab asn1js babel-plugin-istanbul charenc chroma-js crypt diff esquery exenv And 25 more...
Apache-2.0	46	Packages @ampproject/remapping @editorjs/editorjs @humanwhocodes/config-array @humanwhocodes/module-importer @opentelemetry/api @opentelemetry/semantic-conventions @playwright/test @swc/core @swc/core-darwin-arm64 @swc/core-darwin-x64 @swc/core-linux-arm-gnueabihf @swc/core-linux-arm64-gnu @swc/core-linux-arm64-musl @swc/core-linux-x64-gnu @swc/core-linux-x64-musl @swc/core-win32-arm64-msvc @swc/core-win32-ia32-msvc @swc/core-win32-x64-msvc @swc/counter aria-query And 26 more...
ISC	50	Packages @esbuild-plugins/node-globals-polyfill @istanbuljs/load-nyc-config @saleor/app-sdk anymatch boolbase browser-stdout cli-width cliui electron-to-chromium fastq flatted fs.realpath get-caller-file get-own-enumerable-property-symbols glob glob-parent graceful-fs inflight inherits ini And 30 more...
MIT	1124	Packages @adobe/css-tools @apollo/client @ardatan/relay-compiler @ardatan/sync-fetch @babel/code-frame @babel/compat-data @babel/core @babel/generator @babel/helper-annotate-as-pure @babel/helper-compilation-targets @babel/helper-create-class-features-plugin @babel/helper-member-expression-to-functions @babel/helper-module-imports @babel/helper-module-transforms @babel/helper-optimise-call-expression @babel/helper-plugin-utils @babel/helper-replace-supers @babel/helper-simple-access @babel/helper-skip-transparent-expression-wrappers @babel/helper-string-parser And 1104 more...

[github-actions]

merge-reports: Run #4911

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
235	235	0	0	0	0	0	5m40s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

[krzysztofwolski]

I know it's still a draft, but don't forget about the dockerfile and readme :) Easy to miss those two:

• saleor-dashboard/Dockerfile

  Line 1 in c2f5824

  FROM node:18-alpine as builder

• saleor-dashboard/README.md

  Line 30 in c2f5824

  - Node.js v18+

CI test workflow seems to be pulling version from .rc file, but might be worth double checking there.

Spring cleaning so early this year, love it :D

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.63%. Comparing base (6118e0a) to head (f4eb41e).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/components/Money/index.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5438      +/-   ##
==========================================
- Coverage   62.63%   62.63%   -0.01%     
==========================================
  Files        1279     1279              
  Lines       22224    22224              
  Branches     4652     4652              
==========================================
- Hits        13921    13919       -2     
- Misses       7749     7751       +2     
  Partials      554      554              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[witoszekdev]

Thanks @krzysztofwolski ❤️

[witoszekdev]

@andrzejewsky please merge

[andrzejewsky]

@witoszekdev please update readme, mention 20 instead 18 + some short info that 18 is still supported, but we recommend to use 20