Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign specific items in voucher creation #5457

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

poulch
Copy link
Member

@poulch poulch commented Mar 6, 2025

… handle unassigning and assign## Scope of the change

specific-items.mov
assing-countries.mov

Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: 2de9f85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5457 March 6, 2025 13:06 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5457 March 6, 2025 13:12 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5457 March 6, 2025 19:49 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5457 March 10, 2025 13:13 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5457 March 10, 2025 16:37 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5457 March 10, 2025 23:04 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5457 March 10, 2025 23:09 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5457 March 11, 2025 12:09 Destroyed
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 24 lines in your changes missing coverage. Please review.

Project coverage is 62.67%. Comparing base (cbb5e48) to head (2de9f85).

Files with missing lines Patch % Lines
...rc/discounts/components/VoucherCreatePage/utils.ts 19.04% 17 Missing ⚠️
src/discounts/views/VoucherCreate/handlers.ts 20.00% 4 Missing ⚠️
.../VoucherCreatePage/hooks/useSpecificItemsAssign.ts 93.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5457      +/-   ##
==========================================
+ Coverage   62.63%   62.67%   +0.04%     
==========================================
  Files        1279     1283       +4     
  Lines       22224    22313      +89     
  Branches     4425     4438      +13     
==========================================
+ Hits        13919    13984      +65     
- Misses       8264     8288      +24     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot temporarily deployed to pr-5457 March 11, 2025 21:22 Destroyed
@poulch poulch changed the title Add specific product to Voucher create page Assign specific items in voucher creation Mar 11, 2025
@poulch poulch marked this pull request as ready for review March 11, 2025 21:26
@poulch poulch requested a review from a team as a code owner March 11, 2025 21:26
@github-actions github-actions bot temporarily deployed to pr-5457 March 11, 2025 21:28 Destroyed
Copy link

github-actions bot commented Mar 11, 2025

merge-reports: Run #4917

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
235 235 0 0 0 0 0 5m26s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants