Skip to content

Fix log so that it writes to stderr and not log file #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annelau21 merged 3 commits into from
Jul 26, 2024
Merged

Fix log so that it writes to stderr and not log file #277

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f7e96c
Create two seperate metrics - one with a watch type and the other wit…
annelau21 Jul 23, 2024
fd1fd40
fix log level
annelau21 Jul 26, 2024
d3369bf
put config back
annelau21 Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/sloop/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
"github.com/salesforce/sloop/pkg/sloop/webserver"
)

const alsologtostderr = "alsologtostderr"
const logtostderr = "logtostderr"

func RealMain() error {
defer glog.Flush()
Expand Down Expand Up @@ -187,14 +187,14 @@ func RealMain() error {
}

// By default glog will not print anything to console, which can confuse users
// This will turn it on unless user sets it explicitly (with --alsologtostderr=false)
// This will turn it on unless user sets it explicitly (with --logtostderr=false)
func setupStdErrLogging() {
for _, arg := range os.Args[1:] {
if strings.Contains(arg, alsologtostderr) {
if strings.Contains(arg, logtostderr) {
return
}
}
err := flag.Set("alsologtostderr", "true")
err := flag.Set("logtostderr", "true")
if err != nil {
panic(err)
}
Expand Down