fix: prevent undesirable coercion of JSON values #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Jackson JSON serialization library will attempt to coerce JSON values to Java data types when it is inappropriate. This leads to element properties being incorrect for the UTAM JSON grammar. For example, `"public": "true"` will incorrectly be coerced into a boolean value, when it should throw an error. Moreover, newer versions of Jackson (`2.16` and higher) will allow more liberal deserialization of properties that should have object values. This allows an invalid UTAM construct line `"selector": "some-selector"`, which should error, as the value of the `selector` property is expected to be an object, not a string value. This change fixes both issues, correctly throwing errors in cases where the wrong type of a property has been authored into the UTAM PO JSON declarative description file.
lizaiv77
approved these changes
Jun 17, 2025
jimevanssfdc
deleted the
jimevanssfdc/prevent-undesirable-json-type-coercion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jackson JSON serialization library will attempt to coerce JSON values to Java data types when it is inappropriate. This leads to element properties being incorrect for the UTAM JSON grammar. For example,
"public": "true"will incorrectly be coerced into a boolean value, when it should throw an error.Moreover, newer versions of Jackson (
2.16and higher) will allow more liberal deserialization of properties that should have object values. This allows an invalid UTAM construct line"selector": "some-selector", which should error, as the value of theselectorproperty is expected to be an object, not a string value.This change fixes both issues, correctly throwing errors in cases where the wrong type of a property has been authored into the UTAM PO JSON declarative description file.