@W-18480490 - Call to Action link Validation #328
Conversation
| @@ -18,6 +18,7 @@ | |||
| "jsdom": "^25.0.0", | |||
| "lodash.chunk": "^4.2.0", | |||
| "open": "^8.4.2", | |||
| "puppeteer": "^24.12.1", | |||
There was a problem hiding this comment.
Does the same package need to be added in yarn
There was a problem hiding this comment.
Did you validate the use case with plugin as well?
|
LGTM |
| // Helper function to make HTTP request and check if URL is accessible | ||
| async function checkSalesforceUrlWithPuppeteer(url: string): Promise<boolean> { | ||
| const browser = await puppeteer.launch({ headless: true }); // use true instead of 'new' | ||
| const page = await browser.newPage(); |
There was a problem hiding this comment.
Do we need puppeteer here, can't we simply use requests http library to hint the link and check for 200 response code?
There was a problem hiding this comment.
No, the links are not returning the response as 200, they are returning response 301, for valid as well as invalid URLs. And on the redirected URL the error is not coming directly, javascript rendering is first happening on the UI and then the error is showing up, which can not we captured without a browser environment.
There was a problem hiding this comment.
@shaurabh-tiwari-git as discussed add the title check assertion also
yarn.lock
Outdated
| @@ -11,13 +11,13 @@ | |||
|
|
|||
| "@apexdevtools/apex-parser@^4.1.0": | |||
| version "4.1.0" | |||
| resolved "https://registry.yarnpkg.com/@apexdevtools/apex-parser/-/apex-parser-4.1.0.tgz#f8e801a8e4a65ff0e1fb70629642cda76e60fed3" | |||
| resolved "https://registry.npmjs.org/@apexdevtools/apex-parser/-/apex-parser-4.1.0.tgz" | |||
There was a problem hiding this comment.
Do we need to check-in this file or it will be auto built based on package.json changes? Did you check with @snehaljha-sf about it?
There was a problem hiding this comment.
This one is alright @sf-kishore-kurri, it'll ensure we have the exact dependency that have been added during development and validated
What does this PR do?
What issues does this PR fix or reference?