@ W-18480465 - Apex full file diff #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the diff content is even larger then the one is the attached image, then will the scroll bar come? |
| const patch: string = createPatch('', originalFileContent, modifiedFileContent); | ||
| const patchLines = patch.split('\n'); | ||
|
|
||
| let origIdx = 0; |
There was a problem hiding this comment.
How it will show when the single file has multiple changes within file?
| public getFullFileDiff(filename: string, originalFileContent: string, modifiedFileContent: string): DiffPair[] { | ||
| const originalLines = originalFileContent.split('\n'); | ||
| const modifiedLines = modifiedFileContent.split('\n'); | ||
| const patch: string = createPatch('', originalFileContent, modifiedFileContent); |
There was a problem hiding this comment.
instead of writing our own custom logic to derive difference from patch, we can explore and leverage other methods provided by (diff)
Yes, the scrollbar will come when we scroll the file. However it will not always be visible, it will only appear while scrolling. |
shaurabh-tiwari-git
requested review from
sf-aastha-paruthi,
sf-kishore-kurri and
snehaljha-sf
|
@snehaljha-sf Can you approve and merge the changes |
snehaljha-sf
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?