-
Notifications
You must be signed in to change notification settings - Fork 10
@W-19050490: Report labels and error handling #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@W-19050490: Report labels and error handling #336
Conversation
Thanks for the contribution! It looks like @vsushmita @girjeshkumar10 is an internal user so signing the CLA is not required. However, we need to confirm this. |
@@ -74,12 +74,12 @@ export class DRAssessmentReporter { | |||
{ | |||
header: [ | |||
{ | |||
name: 'In Package', | |||
name: 'Managed Package', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these changes coming based on CX reveiw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
<ul class="slds-list_dotted"> | ||
<c:for items=(rollbackFlags) var="flag"> | ||
<li class="slds-item slds-text-color_destructive">{{flag}}</li> | ||
</c:for> | ||
</ul> | ||
<p> | ||
<strong>Note:</strong> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you removed this message of rollback flags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In CX review this line was removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
What does this PR do?
What issues does this PR fix or reference?