Skip to content

@W-19050490: Report labels and error handling #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025

Conversation

snehaljha-sf
Copy link
Collaborator

What does this PR do?

What issues does this PR fix or reference?

@snehaljha-sf snehaljha-sf requested a review from a team as a code owner July 17, 2025 18:13
Copy link

Thanks for the contribution! It looks like @vsushmita @girjeshkumar10 is an internal user so signing the CLA is not required. However, we need to confirm this.

@snehaljha-sf snehaljha-sf changed the base branch from main to prerelease/alpha July 17, 2025 18:13
@@ -74,12 +74,12 @@ export class DRAssessmentReporter {
{
header: [
{
name: 'In Package',
name: 'Managed Package',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these changes coming based on CX reveiw?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

<ul class="slds-list_dotted">
<c:for items=(rollbackFlags) var="flag">
<li class="slds-item slds-text-color_destructive">{{flag}}</li>
</c:for>
</ul>
<p>
<strong>Note:</strong>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you removed this message of rollback flags?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In CX review this line was removed

@snehaljha-sf snehaljha-sf changed the title Report labels and error handling @W-19050490: Report labels and error handling Jul 18, 2025
Copy link

@sf-kishore-kurri sf-kishore-kurri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@snehaljha-sf snehaljha-sf merged commit 5d6edcf into salesforcecli:prerelease/alpha Jul 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants