@W-19050490 fix: mvp bugs #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/migration/related/OmnistudioRelatedObjectMigrationFacade.ts
Outdated
Show resolved
Hide resolved
src/migration/related/OmnistudioRelatedObjectMigrationFacade.ts
Outdated
Show resolved
Hide resolved
src/utils/interfaces.ts
Outdated
| } | ||
|
|
||
| export interface OmniAssessmentInfo { | ||
| osAssessmentInfos: OSAssessmentInfo[]; | ||
| ipAssessmentInfos: IPAssessmentInfo[]; | ||
| } | ||
|
|
||
| export interface SitesAssessmentInfo { | ||
| name: string; |
There was a problem hiding this comment.
clean up this one, it is unused code
snehaljha-sf
commented
Jul 23, 2025
| apexDependencies: [], | ||
| migrationStatus: 'Failed', |
There was a problem hiding this comment.
nit, Failed, Can be Automated, other status can be moved to constants.
| @@ -170,7 +192,18 @@ export class IPAssessmentReporter { | |||
| ]; | |||
| } | |||
|
|
|||
| private static getFilterGroupsForReport(): FilterGroupParam[] { | |||
| return []; | |||
| private static getFilterGroupsForReport(ipAssessmentInfo: IPAssessmentInfo[]): FilterGroupParam[] { | |||
There was a problem hiding this comment.
Can this be moved to some common file/util? Based on migration status the filtering is happening and all four components seem to have that field.
sf-aastha-paruthi
approved these changes
Jul 23, 2025
|
Since the target is prerelease/alpha and not prerelease/alphaGA and the branches would diverge, what is the plan to merge prerelease/alphaGA to main? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?