Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-auto-import 2 #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ember-auto-import 2 #22

wants to merge 4 commits into from

Conversation

jamescdavis
Copy link

@jamescdavis jamescdavis commented Sep 26, 2022

Upgrade to ember-auto-import 2.x

This should probably be a major version bump?

This repo is apparently not set up for CI. But tests pass locally.

@jamescdavis jamescdavis marked this pull request as ready for review September 26, 2022 18:57
Copy link
Member

@dfreeman dfreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo is apparently not set up for CI.

This repo probably hasn't been touched in a meaningful way since Travis still worked

This should probably be a major version bump?

This should be a major bump, since EAI@2 requires the host app to also have it installed IIRC.

Ultimately I think we should probably consider deprecating this package. Most of the work it originally did was getting debug into the build at all, but EAI makes that trivial. The only 'special sauce' left is automatically reading _debugContainerKey from the instance the logger is read from, which is of questionable value at this point compared to just setting an explicit key, IMO.

Regardless I'm happy to ship this change in the meantime 👍


## v2.1.1 - 04/09/2019

This release fixes a bug introduced in `v2.1.0` — `debug@4` contains ES6 syntax that breaks compatibility with IE11. We now lock our `debug` dependency below version 4.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably widen our acceptable version band now since EAI runs Babel against your imported dependencies these days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants