Remove extra space in process title #67779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an extra space in daemons' process title. before: ``` python3.11: MultiMinionProcessManager MinionProcessManager (python3.11) ``` after: ``` python3.11: MultiMinionProcessManager MinionProcessManager (python3.11) ``` The extra space confuses FreeBSD's RC script. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285053
9 tasks
|
@asomers Looks good, can you please add a unit test and changelog? Also, is this something that should be fixed in 3006.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an extra space in daemons' process title.
before:
after:
The extra space confuses FreeBSD's RC script. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285053
What does this PR do?
Changes a double space in the minion's process title into a single space
What issues does this PR fix or reference?
Partially fixes
service salt_minion statusand related commands on FreeBSD. Some additional changes are necessary to completely fix the issue.https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285053
Previous Behavior
The process title had two spaces between "python3.11:" and "MultiMinionProcessManager"
New Behavior
The process title only has one space.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes