Add mdadm and lvm grains back in to core #68470
Draft
+354
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the mdadm and lvm grains back in to core. The were removed as part of the community module migration, but they provide key functionality on linux systems and the associated execution and state modules were not removed.
barneysowood
force-pushed
the
restore-grains-modules
branch
from
b3f4327 to
89d172f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
mdadmandlvmgrains modules back in to core. The were removed as part of the community module migration in #65971, but they provide key functionality on linux systems. The associated execution and state modules (mdadm_raid/mdadmandlinux_lvm/lvm) were not removed so it doesn't seem to make sense that the grains should be in a separate extension.Previous Behavior
mdadmandlvmgrains were not availableNew Behavior
mdadmandlvmgrains are available againMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with SSH key?
Yes