config refactor #244
Merged
config refactor #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Threated
commented
Jun 18, 2025
Threated
force-pushed
the
config-refactor
branch
from
8eadd6a to
c47bc3e
Compare
Threated
force-pushed
the
config-refactor
branch
from
c47bc3e to
b666efb
Compare
Threated
commented
Jul 23, 2025
TKussel
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to split this up into sensible commits but that was close to impossible as the globals where used all over the place.
The code is now much easier to reason about without all the config globals gone leaving the
CERT_GETTERand its cache as the only static inshared.My only concern is that I broke some cli parsing options as I removed
config_sharedand added the options that where actually common to the respective configs.There are probably more clean ups possible as a result of this refactor but this PR is large enough already.