Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary Download #2119

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Binary Download #2119

wants to merge 21 commits into from

Conversation

allentiak
Copy link
Collaborator

Fixes #2108

alexanderkiel
alexanderkiel requested changes Oct 14, 2024
View reviewed changes
docs/implementation/fhir-data-model.md Outdated Show resolved Hide resolved
modules/rest-api/src/blaze/rest_api/routes.clj Outdated Show resolved Hide resolved
modules/rest-api/src/blaze/rest_api/routes.clj Outdated Show resolved Hide resolved
modules/fhir-structure/src/blaze/fhir/spec.clj Outdated Show resolved Hide resolved
modules/rest-util/src/blaze/middleware/fhir/output.clj Outdated Show resolved Hide resolved
modules/rest-util/src/blaze/middleware/fhir/output.clj Outdated Show resolved Hide resolved
modules/rest-util/src/blaze/middleware/fhir/output.clj Outdated Show resolved Hide resolved
modules/rest-util/src/blaze/middleware/fhir/resource.clj Outdated Show resolved Hide resolved
modules/rest-util/src/blaze/middleware/output.clj Outdated Show resolved Hide resolved
modules/rest-util/test/blaze/middleware/fhir/output_test.clj Outdated Show resolved Hide resolved
@allentiak allentiak force-pushed the binary-download branch 3 times, most recently from 8253d14 to 4b8e92b Compare October 15, 2024 12:00
@allentiak allentiak force-pushed the binary-download branch 4 times, most recently from d1e1267 to 3f6a998 Compare October 16, 2024 13:14
allentiak
allentiak commented Oct 17, 2024
View reviewed changes
Copy link
Collaborator Author

@allentiak allentiak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Just re-reviewed my own changes.
Couldn't do that without writing something here...)

@allentiak allentiak force-pushed the binary-download branch 6 times, most recently from 8f87f27 to c1e59ba Compare October 18, 2024 11:33
@allentiak allentiak mentioned this pull request Oct 18, 2024
Open
2 tasks
@allentiak allentiak changed the title Binary download Binary Download Oct 18, 2024
@allentiak allentiak mentioned this pull request Oct 18, 2024
Merged
@allentiak allentiak marked this pull request as ready for review October 21, 2024 18:58
@allentiak allentiak force-pushed the binary-download branch 8 times, most recently from a784230 to abf68c3 Compare November 13, 2024 16:19
@allentiak
reviewed: add support for binary resource download (fixes #2108)
63e2e59 
* also improve clojuredoc strings
@allentiak
fix: refactor encode-response-binary
804cd5d
@allentiak
fix: test
144fdd4
@allentiak
fix: make sure all namespace-specific def's are private
36b24e0
@allentiak
fix: add tests for accept headers
fc08011
@allentiak
fix: refactoring
64cac8d
@allentiak
fix: refactor accept headers test
90a9ba8
@allentiak
add linting checks for consistent aliases
fce1b7d
@allentiak
fix: refactor: are -> doseq (first case)
508a4d2
@allentiak
fix: refactor: are -> doseq (second case)
1db33b8
@allentiak
fix: refactor: are -> doseq (third case)
f80f80d
@allentiak
fix: refactor: are -> doseq (fourth case)
eafe820
@allentiak
fix: refactor: are -> doseq (fifth case)
34af0d6
@allentiak
fix: refactor: are -> doseq (remove unused refer)
01b5023
@allentiak
debug: add print statements
ddf1dd5 
next var to eval: wrap-output
@allentiak
bugfix: move :response-type tag from type to instance
a8b5796
@allentiak
bugfix: binary-resource-handler should return a 200, not a 304
5a2c62e
@allentiak
debug: make println's show more information
51e4e1d
@allentiak
test: fix "failing XML emit"
1dd0616
@allentiak
integration tests: start work (WIP)
b784b7c
@allentiak
integration test: improve non-found test
d4dccd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderkiel alexanderkiel Awaiting requested review from alexanderkiel

Requested changes must be addressed to merge this pull request.

Assignees

@allentiak allentiak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Direct Download of Binary Content at the Binary Endpoint
2 participants
@allentiak @alexanderkiel