Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce license information #33

Closed
wants to merge 1 commit into from

Conversation

blt
Copy link

@blt blt commented Aug 2, 2020

The original Busybox source notes that it is distributed under GPL-2.
This notice was retained in this project in file headers but appeared
to be absent from a top-level notice or in Cargo.toml.

Resolves #1.

The original Busybox source notes that it is distributed under GPL-2.
This notice was retained in this project in file headers but appeared
to be absent from a top-level notice or in Cargo.toml.

Resolves samuela#1.
@blt
Copy link
Author

blt commented Aug 3, 2020

Ah, geez. Looks like CI is not building right now. This PR has no active code changes but there's a whole spew of

error: use of deprecated item 'std::ptr::mut_ptr::<impl *mut T>::wrapping_offset_from': Pointer distances across allocation boundaries are not typically meaningful. Use integer subtraction if you really need this.
   --> util_linux/mount.rs:950:42
    |
950 |     O_len = strchrnul(O_opt, ',' as i32).wrapping_offset_from(O_opt) as libc::c_long as libc::c_int;
    |  

@samuela let me know if you'd be interested in a PR for that.

@samuela
Copy link
Owner

samuela commented Aug 3, 2020

Ah, geez. Looks like CI is not building right now. This PR has no active code changes but there's a whole spew of

error: use of deprecated item 'std::ptr::mut_ptr::<impl *mut T>::wrapping_offset_from': Pointer distances across allocation boundaries are not typically meaningful. Use integer subtraction if you really need this.
   --> util_linux/mount.rs:950:42
    |
950 |     O_len = strchrnul(O_opt, ',' as i32).wrapping_offset_from(O_opt) as libc::c_long as libc::c_int;
    |  

@samuela let me know if you'd be interested in a PR for that.

Yeah, the CI builds off of whatever the current rust is, so when things get deprecate the CI can break without us changing anything. This is good in the sense that it's pressure to stay up-to-date, but annoying when it happens. would most def be interested in a PR for that!

@samuela
Copy link
Owner

samuela commented Aug 3, 2020

The license situation is a bit obnoxious... GPL is a viral license, and so the ultimate plan for the project is to rid ourselves of it completely. The game plan is split the project up with rust workspaces, one for each applet. This way we can rewrite the (tiny) base of rustybox to be whatever license we like and then have the transpiled applets be GPL, and new applets be whatever license. The overall license of a compiled artifact will then be up to the user. Since that's where we're headed I don't want to assign any license to the overall project since it's ultimately going to be replaced. At the moment licensing is at the discretion of users since IANAL, and we can revisit once these rewrites are finished.

@samuela samuela closed this Aug 3, 2020
@blt
Copy link
Author

blt commented Aug 3, 2020

Gotcha.

I'll see about the deprecation.

@blt blt deleted the introduce_license_info branch August 3, 2020 22:35
@blt
Copy link
Author

blt commented Aug 3, 2020

@samuela FWIW that explanation about the license would be helpful in the readme.

@mjholub
Copy link

mjholub commented Apr 9, 2023

Ah, geez. Looks like CI is not building right now. This PR has no active code changes but there's a whole spew of

error: use of deprecated item 'std::ptr::mut_ptr::<impl *mut T>::wrapping_offset_from': Pointer distances across allocation boundaries are not typically meaningful. Use integer subtraction if you really need this.
   --> util_linux/mount.rs:950:42
    |
950 |     O_len = strchrnul(O_opt, ',' as i32).wrapping_offset_from(O_opt) as libc::c_long as libc::c_int;
    |  

@samuela let me know if you'd be interested in a PR for that.

Yeah, the CI builds off of whatever the current rust is, so when things get deprecate the CI can break without us changing anything. This is good in the sense that it's pressure to stay up-to-date, but annoying when it happens. would most def be interested in a PR for that!

argh. Sorry for necroposting... but I've just opened a PR that's basically a duplicate of this.

Tbh I'm a kind of person for which such task as integrating breaking changes from updated dependencies/toolchain doesn't seem mundane, so I'd be glad to attempt to solve them iff there are still plans for further development of this project which I consider so badly needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPLv2 licence and original authors should be more clearly shown
3 participants