Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Importer #13

Merged
2 commits merged into from
Jul 11, 2019
Merged

CSV Importer #13

2 commits merged into from
Jul 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 4, 2019

First pass at a CSV Importer, currently:

  • supports metadata
  • supports multiple file upload from a local folder, depends on a 'file' column in the csv with multiple values separated with | or ; (also small refactoring of the object factory to support multiple files)
  • csv file must exist on server already; files must be in a folder called files within the same dir as the csv (working on principle we'll have an import path, eg. tmp/imports/import_no/
  • supports rights statement override
  • sets visibility to open (unless it's already set in a column called visibility)
  • requires a column called 'identifier' in the CSV
  • skips lines without an identifier
  • validates required fields (static list at present)

@todo

@ghost ghost changed the title WIP CSV Importer CSV Importer Jul 8, 2019
@ghost ghost mentioned this pull request Jul 8, 2019
Copy link
Member

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really solid. One performance related question, but all the rest are pretty niggly things =-D

app/factories/bulkrax/object_factory.rb Outdated Show resolved Hide resolved
app/models/bulkrax/concerns/has_matchers.rb Show resolved Hide resolved
app/models/bulkrax/entry.rb Show resolved Hide resolved
app/models/bulkrax/entry.rb Show resolved Hide resolved
app/parsers/bulkrax/csv_parser.rb Outdated Show resolved Hide resolved
app/parsers/bulkrax/csv_parser.rb Outdated Show resolved Hide resolved
Copy link
Member

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when ready

@ghost ghost merged commit 3aad371 into master Jul 11, 2019
@ghost ghost deleted the csv_importer branch July 11, 2019 07:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant