Add seeding for BiRB designs #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add in the rest of the plumbing needed for deterministically random BiRB experiment design construction.
sserita
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Thanks for taking care of this. I'll note that this is using the new RNG interface instead of the old one that most of the codebase is using; however, we want to probably shift to this one, so I'll approve here and we'll migrate the others as part of dealing with #548 or a separate but related issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #546 and adds in the rest of the plumbing needed for deterministically random BiRB experiment design construction. Previously even when specifying a seed this wasn't being propagated through to all of the different random sampling steps (or in some cases these sampling steps weren't configured to take a seed) meaning that the results were unexpectedly still non-deterministic (which is a problem where reproducibility guarantees are required.