docs(binaryPlus): define number + datetime to make this operation commutative #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kbrabrand
commented
Dec 9, 2025
atombender
approved these changes
Dec 9, 2025
Member
atombender
left a comment
atombender
left a comment
There was a problem hiding this comment.
LGTM. Have you confirmed this is the currently implemented behaviour in the query API and GROQ.js?
Contributor
Author
|
Yes. The change was prompted by a user reporting that |
Member
|
Great! |
Contributor
Author
kbrabrand
deleted the
docs/cldx-4469/commutative-addition-number-datetime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add addition of dateTime to number to the spec to reflect the actual implementation.
What changed?
The spec currently defines
dateTime + number ⇒ dateTimeandnumber + dateTime ⇒ null, while it has been implemented as a commutative operation in the query engine, meaning that the order of the operands is irrelevant.With this change the spec defines this as a commutative operation, reflecting the actual implementation.