fix: import lazy MuxPlayer to avoid schema extraction errors #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@R-Delfino95 is attempting to deploy a commit to the Sanity Sandbox Team on Vercel. A member of the Team first needs to authorize it. |
R-Delfino95
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #444, which caused a crash when running
sanity schema extractbecause@mux/mux-player-reacttried to access browser-only APIs (likeDOMParser) in a Node environment.Thanks to @RJWadley for identifying the issue and opening the initial PR (#445) 🙏
@mux/mux-player-reactalready provides a built-in lazy loading implementation, which ensures the player only loads in the browser. Using that version fully resolves the crash without requiring other component changes.Testing
npm ci && npx sanity schema extractnpx sanity typegen generateNotes