-
Notifications
You must be signed in to change notification settings - Fork 73
feat: configure mime/type option #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pintorado
wants to merge
10
commits into
sanity-io:main
Choose a base branch
from
Pintorado:feat/configure-mime/type-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: configure mime/type option #453
Pintorado
wants to merge
10
commits into
sanity-io:main
from
Pintorado:feat/configure-mime/type-option
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pintorado is attempting to deploy a commit to the Sanity Sandbox Team on Vercel. A member of the Team first needs to authorize it. |
…placeholder image for audios to the VideoPlayer
…lect support for both video and audio files
…tely reflect support for both video and audio files" This reverts commit 03031e4.
R-Delfino95
approved these changes
Dec 3, 2025
Collaborator
|
LGTM! |
stipsan
approved these changes
Dec 4, 2025
Member
stipsan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 💖
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves audio file handling in the Mux plugin and adds configurable MIME type validation. It builds upon the work from PR #398 by @isaac-martin.
Closes issue #382, which calls for better audio file handling and support in the plugin, and it also closes #407 by fixing the state of the input on dragEnter for audios.
What to review
acceptedMimeTypesconfiguration option that allows configuring which file types are accepted by the input ('video/*'and/or'audio/*'). Default value is['video/*', 'audio/*']README.mdwith comprehensive documentation for theacceptedMimeTypesconfiguration option.Testing
There are 2 options to configure the
acceptedMimeTypes:1) Plugin-level configuration
Configure accepted file types for all
mux.videofields globally:2) Schema-level configuration
Configure accepted file types for individual fields in your schema, which will override the plugin-level configuration:
Try uploading audios, videos and other unsupported file types in the different uploaders. Verify that each uploader accepts only the file types specified in its
acceptedMimeTypesconfiguration (by default, accepts both audio and video files). After uploading an audio, check that the preview displays correctly.